OSDN Git Service

drm/vblank: Use u32 consistently for vblank counters
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 7 Aug 2015 10:31:17 +0000 (12:31 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 7 Aug 2015 12:35:53 +0000 (14:35 +0200)
commit209e4dbc8dcdb2b1839f18fd1cf07ec7bedadf4d
treec9722b8253e9cd427c7d919280416111c3b5048f
parent047fe6e6db9161e69271f56daaafdaf2add023b1
drm/vblank: Use u32 consistently for vblank counters

In

commit 99264a61dfcda41d86d0960cf2d4c0fc2758a773
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed Apr 15 19:34:43 2015 +0200

    drm/vblank: Fixup and document timestamp update/read barriers

I've switched vblank->count from atomic_t to unsigned long and
accidentally created an integer comparison bug in
drm_vblank_count_and_time since vblanke->count might overflow the u32
local copy and hence the retry loop never succeed.

Fix this by consistently using u32.

Cc: Michel Dänzer <michel@daenzer.net>
Reported-by: Michel Dänzer <michel@daenzer.net>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
drivers/gpu/drm/drm_irq.c
include/drm/drmP.h