OSDN Git Service

staging: rtl8188eu: fix possible null dereference
authorConnor Kuehl <connor.kuehl@canonical.com>
Thu, 26 Sep 2019 15:03:17 +0000 (08:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Sep 2019 19:58:02 +0000 (21:58 +0200)
commit228241944a48113470d3c3b46c88ba7fbe0a274b
treef768c9bea73cddb0f204a9fd5f0abf31bad45898
parentc47be36db3283bdcc071b55ccbb366fba1f57b2f
staging: rtl8188eu: fix possible null dereference

Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else if' where 'psta' is dereferenced, then we will dereference
a NULL pointer.

Fix this by checking if 'psta' is not NULL before reading its
'psta->qos_option' data member.

Addresses-Coverity: ("Dereference null return value")

Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Link: https://lore.kernel.org/r/20190926150317.5894-1-connor.kuehl@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_xmit.c