OSDN Git Service

drm/nouveau/kms/nvd9-nv138: Fix CRC calculation for the cursor channel
authorLyude Paul <lyude@redhat.com>
Tue, 23 Feb 2021 23:56:47 +0000 (18:56 -0500)
committerKarol Herbst <kherbst@redhat.com>
Fri, 12 Nov 2021 22:46:03 +0000 (23:46 +0100)
commit23244f67ed96c76428bfdfc63eef642e4d627825
tree40ccb877b248b02cfae61bba151f5b2f334b0450
parent57cbdbe65e5f9ba9bfd67b66bc3ce24ef1c54643
drm/nouveau/kms/nvd9-nv138: Fix CRC calculation for the cursor channel

Something that didn't get noticed until I started running cursor tests:
we're accidentally disabling an option for CRC calculation that's enabled
by default: WidePipeCrc, which controls whether we use the full width of
the data in the display pipe in order calculate CRCs. Having this disabled
apparently causes frames with the cursor plane enabled to generate
different CRCs than frames without the cursor plane enabled, even if the
frames are pixel-equivalent.

So, let's make sure to enable this and fix a bunch of cursor related tests
in IGT.

v2:
* Nvidia added the specific bit we were using to fix this issues to
  open-gpu-docs, so pull in the actual macro definitions for it

Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
Cc: Simon Ser <contact@emersion.fr>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Link: https://gitlab.freedesktop.org/drm/nouveau/-/merge_requests/10
drivers/gpu/drm/nouveau/dispnv50/crc907d.c
drivers/gpu/drm/nouveau/include/nvhw/class/cl907d.h