OSDN Git Service

macintosh/adb: Rework printk output again
authorFinn Thain <fthain@telegraphics.com.au>
Wed, 12 Sep 2018 00:18:44 +0000 (20:18 -0400)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 8 Oct 2018 11:53:10 +0000 (22:53 +1100)
commit2341629eadc4a40aa46103c7f1ff5f38459688d3
tree7ef371c2b3b07b075d3225006403444feebaec17
parent0792a2c8e0bbda3605b8d42c6b9635be7b19982a
macintosh/adb: Rework printk output again

Avoid the KERN_CONT problem by avoiding message fragments. The problem
arises during async ADB bus probing, when ADB messages may get mixed up
with other messages. See also, commit 4bcc595ccd80 ("printk: reinstate
KERN_CONT for printing continuation lines").

Remove a number of printk() continuation lines by logging handler
changes in adb_try_handler_change() instead.

This patch addresses the problematic use of "\n" at the beginning of
pr_cont() messages, which got overlooked in commit f2be6295684b
("macintosh/adb: Properly mark continued kernel messages").

That commit also changed printk(KERN_DEBUG ...) to pr_debug(...), which
hinders work on low-level ADB driver bugs. Revert that change.

Cc: Andreas Schwab <schwab@linux-m68k.org>
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/macintosh/adb.c
drivers/macintosh/adbhid.c