OSDN Git Service

bonding: pair enable_port with slave_arr_updates
authorMahesh Bandewar <maheshb@google.com>
Mon, 7 Feb 2022 22:29:01 +0000 (14:29 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 9 Feb 2022 01:03:30 +0000 (17:03 -0800)
commit23de0d7b6f0e3f9a6283a882594c479949da1120
tree741ff9ad2c72d34455f249ef8d65ec0fd4a5abc8
parent084cbb2ec3af2d23be9de65fcc9493e21e265859
bonding: pair enable_port with slave_arr_updates

When 803.2ad mode enables a participating port, it should update
the slave-array. I have observed that the member links are participating
and are part of the active aggregator while the traffic is egressing via
only one member link (in a case where two links are participating). Via
kprobes I discovered that slave-arr has only one link added while
the other participating link wasn't part of the slave-arr.

I couldn't see what caused that situation but the simple code-walk
through provided me hints that the enable_port wasn't always associated
with the slave-array update.

Fixes: ee6377147409 ("bonding: Simplify the xmit function for modes that use xmit_hash")
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Link: https://lore.kernel.org/r/20220207222901.1795287-1-maheshb@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/bonding/bond_3ad.c