OSDN Git Service

media: saa7134: improve f->fmt.win.clips NULL check
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 10 Nov 2020 08:10:51 +0000 (09:10 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 17 Nov 2020 06:13:27 +0000 (07:13 +0100)
commit23ffa0399c693246a7442b98d71265e92e827912
tree37d9faadddca426b7e67f549ccba4409c9dffb6c
parent88c660840c7c78e7a041a88cb33492258b8dae73
media: saa7134: improve f->fmt.win.clips NULL check

Fix this smatch error:

saa7134-video.c:1286 saa7134_g_fmt_vid_overlay() error: we previously assumed 'f->fmt.win.clips' could be null (see line 1279)

This is actually a false error since if f->fmt.win.clips is NULL, clipcount
will be set to 0, so the clips array won't be touched, but it doesn't hurt
to make this explicit in the code.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/saa7134/saa7134-video.c