OSDN Git Service

NativeDaemonConnector: Fix SDCard mounting bug in the emulator.
authorDavid 'Digit' Turner <digit@google.com>
Thu, 16 Jun 2011 15:40:23 +0000 (17:40 +0200)
committerDavid 'Digit' Turner <digit@google.com>
Thu, 7 Jul 2011 01:46:00 +0000 (03:46 +0200)
commit2435a927f30efe38c673bfaed64a9880028da9e8
tree57fa09de7c2b5772bd36f2cc67ef6072167e9145
parent0a9b16d158d0c8d3be3c19ba1ed15920a3f44a9d
NativeDaemonConnector: Fix SDCard mounting bug in the emulator.

This patch fixes a really annoying bug that prevented the emulator
from properly mounting the SD Card.

The issue was that mOutputStream was not initialized when the onDaemonConnected
callbacks are called, just after the daemon's socket connection is established.

In one specific case (MountService a.k.a. VoldConnector), the corresponding
callback function immediately tried to perform a doCommandList() call on the
connector object. The request failed because mOutputStream was still defined
as null when it happened.

By moving the initialization of the variable just before the callback is
invoked, we ensure that things work properly.

Change-Id: I46726a50ef69eaafe70081ff4eda1244b744beba
services/java/com/android/server/NativeDaemonConnector.java