OSDN Git Service

drm/i915: Move fd_install after last use of fence
authorRob Clark <robdclark@chromium.org>
Fri, 3 Feb 2023 16:49:20 +0000 (08:49 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 6 Feb 2023 13:15:47 +0000 (08:15 -0500)
commit251e8c5b1b1fadcc387a8e618c7437d330bdac3e
tree2f23de8dda117593dc5b9585a60b3a3365b91e62
parent039a72ce7e570c56713fe7758a0658034dc48c9b
drm/i915: Move fd_install after last use of fence

Because eb_composite_fence_create() drops the fence_array reference
after creation of the sync_file, only the sync_file holds a ref to the
fence.  But fd_install() makes that reference visable to userspace, so
it must be the last thing we do with the fence.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Fixes: 00dae4d3d35d ("drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)")
Cc: <stable@vger.kernel.org> # v5.15+
[tursulin: Added stable tag.]
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230203164937.4035503-1-robdclark@gmail.com
(cherry picked from commit 960dafa30455450d318756a9896a02727f2639e0)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c