OSDN Git Service

qmp-dispatch: Use CommandNotFound error for disabled commands
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 30 Aug 2019 13:29:45 +0000 (15:29 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Sat, 28 Sep 2019 14:51:30 +0000 (16:51 +0200)
commit2546be1c85913da46fe4fb15fefdcbfad026a7df
treeb5fe67d21f17b1f79a3e6ab62d378691b4a02291
parentc6f5012ba5fa834cbd5274b1b8369e2c5d2f5933
qmp-dispatch: Use CommandNotFound error for disabled commands

If a command is disabled an error is reported.  But due to usage of
error_setg() the class of the error is GenericError which does not
help callers in distinguishing this case from a case where a qmp
command fails regularly due to other reasons.

We used to use class CommandDisabled until the great error
simplification (commit de253f1491 for QMP and commit 93b91c59db for
qemu-ga, both v1.2.0).

Use CommandNotFound error class, which is close enough.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Message-Id: <faeb030e6a1044f0fd88208edfdb1c5fafe5def9.1567171655.git.mprivozn@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[Test update squashed in, commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
qapi/qmp-dispatch.c
tests/test-qga.c