OSDN Git Service

drbd: remove check of list iterator against head past the loop body
authorJakob Koschel <jakobkoschel@gmail.com>
Thu, 31 Mar 2022 22:03:49 +0000 (00:03 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 31 Mar 2022 23:08:15 +0000 (17:08 -0600)
commit2651ee5ae43241831ca63d7158bb2b151a6a0e1f
tree0ef23516e636cc4c4edd5f153570a781cb0cfe5f
parent901aeda62efa21f2eae937bccb71b49ae531be06
drbd: remove check of list iterator against head past the loop body

When list_for_each_entry() completes the iteration over the whole list
without breaking the loop, the iterator value will be a bogus pointer
computed based on the head element.

While it is safe to use the pointer to determine if it was computed
based on the head element, either with list_entry_is_head() or
&pos->member == head, using the iterator variable after the loop should
be avoided.

In preparation to limit the scope of a list iterator to the list
traversal loop, use a dedicated pointer to point to the found element [1].

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Link: https://lore.kernel.org/r/20220331220349.885126-2-jakobkoschel@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_req.c