OSDN Git Service

tracing/histograms: Fix parsing of "sym-offset" modifier
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 7 Jul 2021 15:08:21 +0000 (11:08 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 7 Jul 2021 17:14:21 +0000 (13:14 -0400)
commit26c563731056c3ee66f91106c3078a8c36bb7a9e
tree770d40aacb5530ab3cf707e06974bb70abe4005c
parent4030a6e6a6a4a42ff8c18414c9e0c93e24cc70b8
tracing/histograms: Fix parsing of "sym-offset" modifier

With the addition of simple mathematical operations (plus and minus), the
parsing of the "sym-offset" modifier broke, as it took the '-' part of the
"sym-offset" as a minus, and tried to break it up into a mathematical
operation of "field.sym - offset", in which case it failed to parse
(unless the event had a field called "offset").

Both .sym and .sym-offset modifiers should not be entered into
mathematical calculations anyway. If ".sym-offset" is found in the
modifier, then simply make it not an operation that can be calculated on.

Link: https://lkml.kernel.org/r/20210707110821.188ae255@oasis.local.home
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: stable@vger.kernel.org
Fixes: 100719dcef447 ("tracing: Add simple expression support to hist triggers")
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c