OSDN Git Service

USB: usbdevfs: sanitize flags more
authorOliver Neukum <oneukum@suse.com>
Wed, 5 Sep 2018 10:07:02 +0000 (12:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Oct 2018 06:52:08 +0000 (08:52 +0200)
commit26eaa502770cfe4412e57a8151c8eea7247d1ec4
tree575ff0797a009e41c53b44440d8960b329579ed2
parent78769e876f5762f0a3cbd2e0c08e93dd81463339
USB: usbdevfs: sanitize flags more

commit 7a68d9fb851012829c29e770621905529bd9490b upstream.

Requesting a ZERO_PACKET or not is sensible only for output.
In the input direction the device decides.
Likewise accepting short packets makes sense only for input.

This allows operation with panic_on_warn without opening up
a local DOS.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+843efa30c8821bd69f53@syzkaller.appspotmail.com
Fixes: 0cb54a3e47cb ("USB: debugging code shouldn't alter control flow")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/devio.c