OSDN Git Service

hw/isa/i82378: Propagate error if PC_SPEAKER device creation failed
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Fri, 20 Oct 2023 10:08:21 +0000 (12:08 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 7 Nov 2023 12:08:48 +0000 (13:08 +0100)
commit2798ee63b03a8a67017c4fa5ef21fc85bfef67d5
treeb931c9d609b21f353497dc22f1896d9402448c32
parente265ee4379a62949133ce3b5d1b4b4b12a884944
hw/isa/i82378: Propagate error if PC_SPEAKER device creation failed

In commit 40f8214fcd ("hw/audio/pcspk: Inline pcspk_init()")
we neglected to give a change to the caller to handle failed
device creation cleanly. Respect the caller API contract and
propagate the error if creating the PC_SPEAKER device ever
failed. This avoid yet another bad API use to be taken as
example and copy / pasted all over the code base.

Reported-by: Bernhard Beschow <shentey@gmail.com>
Suggested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20231020171509.87839-5-philmd@linaro.org>
hw/isa/i82378.c