OSDN Git Service

drm/i915/execlists: Add a comment for the extra MI_ARB_ENABLE
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 5 Oct 2017 19:10:05 +0000 (20:10 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 6 Oct 2017 22:21:11 +0000 (23:21 +0100)
commit279f5a00c9a9b39f4f6e9813e6d4da8c181d34c8
tree9fb8a87aea5ad47968378a16cc0d9973ab98ddad
parent8d550824c6f52506754f11cb6be51aa153cc580d
drm/i915/execlists: Add a comment for the extra MI_ARB_ENABLE

Michel Thierry noticed that we were applying WaDisableCtxRestoreArbitration
even to gen9, which does not require the w/a. The rationale is that we
need to enable MI arbitration for execlists to work, and to be safe we
do that before every batch (in addition to every context switch into the
batch). Since this is not clear from the single line comment suggesting
the MI_ARB_ENABLE is solely for the w/a, add a little more detail.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: MichaƂ Winiarski <michal.winiarski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171005191005.13462-1-chris@chris-wilson.co.uk
Reviewed-by: Michel Thierry <michel.thierry@intel.com>
drivers/gpu/drm/i915/intel_lrc.c