OSDN Git Service

wan: lmc: fix error return code
authorJulia Lawall <julia.lawall@lip6.fr>
Sun, 5 Apr 2015 12:06:21 +0000 (14:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Apr 2015 19:21:54 +0000 (15:21 -0400)
commit27d751bfa41bdc022d1357479ff67c6902c02c8c
tree8308ab4507f425d3c34b1298f6aab20c5bc1d8fe
parent7abccdba25be45630eede85053496f1f48d36ec8
wan: lmc: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/lmc/lmc_main.c