OSDN Git Service

tty: serial: qcom_geni_serial: Drop useless check for dev.of_node
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 23 Aug 2018 21:30:27 +0000 (23:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2018 14:07:24 +0000 (16:07 +0200)
commit2843cbb5d3c467a85112f004a8a9345370760520
tree200a9bfe9e37ae0a9e3c469f163e406da1e04c80
parent5963e8a3122471cadfe0eba41c4ceaeaa5c8bb4d
tty: serial: qcom_geni_serial: Drop useless check for dev.of_node

With gcc 4.1.2:

    drivers/tty/serial/qcom_geni_serial.c: In function ‘qcom_geni_serial_probe’:
    drivers/tty/serial/qcom_geni_serial.c:1261: warning: ‘drv’ may be used uninitialized in this function

Indeed, if dev.of_node is NULL, drv will be used uninitialized, and
dereferenced in uart_add_one_port().  However, as this driver supports
DT only, dev.of_node will always be valid.

Hence remove the useless check for dev.of_node, killing the warning as a
side effect.

Fixes: 8a8a66a1a18a1dbd ("tty: serial: qcom_geni_serial: Add support for flow control")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c