OSDN Git Service

migration: Fix possible race when setting rp_state.error
authorFabiano Rosas <farosas@suse.de>
Mon, 18 Sep 2023 17:28:16 +0000 (14:28 -0300)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 27 Sep 2023 17:58:02 +0000 (13:58 -0400)
commit28a8347281e24c2e7bba6d3301472eda41d4c096
tree6744fa85c00ff75532b934c7e0d798bebc8f3141
parentcf02f29e1e3843784630d04783e372fa541a77e5
migration: Fix possible race when setting rp_state.error

We don't need to set the rp_state.error right after a shutdown because
qemu_file_shutdown() always sets the QEMUFile error, so the return
path thread would have seen it and set the rp error itself.

Setting the error outside of the thread is also racy because the
thread could clear it after we set it.

Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230918172822.19052-3-farosas@suse.de>
migration/migration.c