OSDN Git Service

iscsi-target: Fix potential NULL pointer in solicited NOPOUT reject
authorNicholas Bellinger <nab@linux-iscsi.org>
Sat, 24 Aug 2013 05:28:56 +0000 (22:28 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 24 Aug 2013 05:51:16 +0000 (22:51 -0700)
commit28aaa950320fc7b8df3f6d2d34fa7833391a9b72
treedca36099b9bf34d0d5f3b4cddce690a74da97493
parentc9a03c12464c851e691e8d5b6c9deba779c512e0
iscsi-target: Fix potential NULL pointer in solicited NOPOUT reject

This patch addresses a potential NULL pointer dereference regression in
iscsit_setup_nop_out() code, specifically for two cases when a solicited
NOPOUT triggers a ISCSI_REASON_PROTOCOL_ERROR reject to be generated.

This is because iscsi_cmd is expected to be NULL for solicited NOPOUT
case before iscsit_process_nop_out() locates the descriptor via TTT
using iscsit_find_cmd_from_ttt().

This regression was originally introduced in:

commit ba159914086f06532079fc15141f46ffe7e04a41
Author: Nicholas Bellinger <nab@linux-iscsi.org>
Date:   Wed Jul 3 03:48:24 2013 -0700

    iscsi-target: Fix iscsit_add_reject* usage for iser

Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target.c