OSDN Git Service

plca.c: fix obvious mistake in checking retval
authorPiergiorgio Beruto <piergiorgio.beruto@gmail.com>
Fri, 13 Jan 2023 13:26:35 +0000 (14:26 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 Jan 2023 05:42:53 +0000 (21:42 -0800)
commit28dbf774bc879c1841d58cb711aaea6198955b95
tree354e5f6a7f72fb0f3455d57101325c6d99582dfb
parentda1b0b5c1bebf4e8f9291f9dcd95b49e70ef28cf
plca.c: fix obvious mistake in checking retval

Revert a wrong fix that was done during the review process. The
intention was to substitute "if(ret < 0)" with "if(ret)".
Unfortunately, the intended fix did not meet the code.
Besides, after additional review, it was decided that "if(ret < 0)"
was actually the right thing to do.

Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/f2277af8951a51cfee2fb905af8d7a812b7beaf4.1673616357.git.piergiorgio.beruto@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/plca.c