OSDN Git Service

vt6655: Fix a possible sleep-in-atomic bug in vt6655_suspend
authorJia-Ju Bai <baijiaju1990@163.com>
Mon, 9 Oct 2017 08:45:55 +0000 (16:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2017 09:07:33 +0000 (10:07 +0100)
commit28e006e14ff9b2fe55078c02bb92212b09664517
tree51500cd15eb8538354848eddfedbb59d59caa704
parent04d5a2d5d2d079ce5966d7e67324c9c4f648c951
vt6655: Fix a possible sleep-in-atomic bug in vt6655_suspend

[ Upstream commit 42c8eb3f6e15367981b274cb79ee4657e2c6949d ]

The driver may sleep under a spinlock, and the function call path is:
vt6655_suspend (acquire the spinlock)
  pci_set_power_state
    __pci_start_power_transition (drivers/pci/pci.c)
      msleep --> may sleep

To fix it, pci_set_power_state is called without having a spinlock.

This bug is found by my static analysis tool and my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/device_main.c