OSDN Git Service

usbip: prevent vhci_hcd driver from leaking a socket pointer address
authorShuah Khan <shuahkh@osg.samsung.com>
Thu, 7 Dec 2017 21:16:49 +0000 (14:16 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jan 2018 11:06:07 +0000 (12:06 +0100)
commit28f467e0bdda754aa36390fd90b01823f0d3b18d
treed34127573fea683de452a81f3858e8ffbef814fc
parent8bb0c6a1b3b2fe92707ee6f6901bfdfc392f8cd1
usbip: prevent vhci_hcd driver from leaking a socket pointer address

commit 2f2d0088eb93db5c649d2a5e34a3800a8a935fc5 upstream.

When a client has a USB device attached over IP, the vhci_hcd driver is
locally leaking a socket pointer address via the

/sys/devices/platform/vhci_hcd/status file (world-readable) and in debug
output when "usbip --debug port" is run.

Fix it to not leak. The socket pointer address is not used at the moment
and it was made visible as a convenient way to find IP address from socket
pointer address by looking up /proc/net/{tcp,tcp6}.

As this opens a security hole, the fix replaces socket pointer address with
sockfd.

Reported-by: Secunia Research <vuln@secunia.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/usbip_common.h
drivers/usb/usbip/vhci_sysfs.c
tools/usb/usbip/libsrc/vhci_driver.c