OSDN Git Service

net: macvlan: fix potential UAF problem for lowerdev
authorZiyang Xuan <william.xuanziyang@huawei.com>
Fri, 11 Mar 2022 09:03:26 +0000 (17:03 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2022 10:06:53 +0000 (10:06 +0000)
commit291ac68478d95cb2b897915da3dc13c6e86d2218
treee71af94165f3d430a0b71368c1a7cfebd445b5cf
parentde29aff976d3216e7f3ab41fcd7af46fa8f7eab7
net: macvlan: fix potential UAF problem for lowerdev

Add the reference operation to lowerdev of macvlan to avoid
the potential UAF problem under the following known scenario:

Someone module puts the NETDEV_UNREGISTER event handler to a
work, and lowerdev is accessed in the work handler. But when
the work is excuted, lowerdev has been destroyed because upper
macvlan did not get reference to lowerdev correctly.

That likes as the scenario occurred by
commit 563bcbae3ba2 ("net: vlan: fix a UAF in vlan_dev_real_dev()").

Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvlan.c