OSDN Git Service

tracing: Replace strlcpy with strscpy in trace/events/task.h
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Thu, 31 Aug 2023 19:42:12 +0000 (19:42 +0000)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Sat, 2 Sep 2023 01:00:00 +0000 (21:00 -0400)
commit2933d3cd079d3bf6fded709de7d97c1dc71d9633
treef704d30967eb2ac4db90528007c8be967261b68e
parent3163f635b20e9e1fb4659e74f47918c9dddfe64e
tracing: Replace strlcpy with strscpy in trace/events/task.h

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().

No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Link: https://lore.kernel.org/linux-trace-kernel/20230831194212.1529941-1-azeemshaikh38@gmail.com
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
include/trace/events/task.h