OSDN Git Service

qapi: Shorter visits of optional fields
authorEric Blake <eblake@redhat.com>
Wed, 2 Dec 2015 05:20:53 +0000 (22:20 -0700)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 17 Dec 2015 07:21:29 +0000 (08:21 +0100)
commit29637a6ee913df8fcdf371426ee48956b945b618
tree8d2c3369074919498d62828d2a624a355ba1a2c3
parent5cdc8831a795fb8452d7e34f644202fd724e122a
qapi: Shorter visits of optional fields

For less code, reflect the determined boolean value of an optional
visit back to the caller instead of making the caller read the
boolean after the fact.

The resulting generated code has the following diff:

|-    visit_optional(v, &has_fdset_id, "fdset-id");
|-    if (has_fdset_id) {
|+    if (visit_optional(v, &has_fdset_id, "fdset-id")) {
|         visit_type_int(v, &fdset_id, "fdset-id", &err);
|         if (err) {
|             goto out;
|         }
|     }

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1449033659-25497-10-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/qapi/visitor.h
qapi/qapi-visit-core.c
scripts/qapi.py