OSDN Git Service

media: vimc: stream: fix thread state before sleep
authorHelen Fornazier <helen.koike@collabora.com>
Wed, 6 Mar 2019 22:42:38 +0000 (17:42 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 19 Mar 2019 19:27:22 +0000 (15:27 -0400)
commit2978a505aaa981b279ef359f74ba93d25098e0a0
tree8a6dbce7956bb9fcfc7cedf8a4483ccd603096ed
parent85ab1aa1fac17bcd79d6d08f835957b46870d0d0
media: vimc: stream: fix thread state before sleep

The state TASK_UNINTERRUPTIBLE should be set just before
schedule_timeout() call, so it knows the sleep mode it should enter.
There is no point in setting TASK_UNINTERRUPTIBLE at the initialization
of the thread as schedule_timeout() will set the state back to
TASK_RUNNING.

This fixes a warning in __might_sleep() call, as it's expecting the
task to be in TASK_RUNNING state just before changing the state to
a sleeping state.

Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vimc/vimc-streamer.c