OSDN Git Service

drm/rockchip: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Sun, 26 Aug 2018 18:47:12 +0000 (13:47 -0500)
committerHeiko Stuebner <heiko@sntech.de>
Wed, 29 Aug 2018 11:39:58 +0000 (13:39 +0200)
commit29adeb4f954b2e398c75d71bd49e62b0287d50c7
treec1187c99fd3e3cc5d1df42b75e85f01408182584
parentdc879f61c45d0f28ba52ddbded2cdd82117f458e
drm/rockchip: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
int stuff;
        void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

or, like in this particular case:

size = sizeof(struct foo) + sizeof(void *) * count;
instance = devm_kzalloc(dev, size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count),
GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20180826184712.GA9330@embeddedor.com
drivers/gpu/drm/rockchip/rockchip_drm_vop.c