OSDN Git Service

[media] media: entity: Catch unbalanced media_pipeline_stop calls
authorKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Tue, 3 Jan 2017 13:12:11 +0000 (11:12 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 23 Jun 2017 12:23:36 +0000 (09:23 -0300)
commit2a2599c663684a1142dae0bff7737e125891ae6d
treeeda500933adb576aa67adc23fb3eb83150ff3588
parent8780f1d9d696c7f466a0ff2a2016476a7ebf42b6
[media] media: entity: Catch unbalanced media_pipeline_stop calls

Drivers must not perform unbalanced calls to stop the entity pipeline,
however if they do they will fault in the core media code, as the
entity->pipe will be set as NULL. We handle this gracefully in the core
with a WARN for the developer.

Replace the erroneous check on zero streaming counts, with a check on
NULL pipe elements instead, as this is the symptom of unbalanced
media_pipeline_stop calls.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pincharts@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/media-entity.c