OSDN Git Service

dpaa2-switch: fix default return of dpaa2_switch_flower_parse_mirror_key
authorTom Rix <trix@redhat.com>
Mon, 14 Feb 2022 15:41:39 +0000 (07:41 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Feb 2022 14:31:43 +0000 (14:31 +0000)
commit2a36ed7c1cd55742503bed81d2cc0ea83bd0ad0c
treef16572374f1d293c0d182c5ff2c0b548ae0c9693
parent9d2d38c35e7a3de96340c446f3b0fde7b2e7348e
dpaa2-switch: fix default return of dpaa2_switch_flower_parse_mirror_key

Clang static analysis reports this representative problem
dpaa2-switch-flower.c:616:24: warning: The right operand of '=='
  is a garbage value
  tmp->cfg.vlan_id == vlan) {
                   ^  ~~~~
vlan is set in dpaa2_switch_flower_parse_mirror_key(). However
this function can return success without setting vlan.  So
change the default return to -EOPNOTSUPP.

Fixes: 0f3faece5808 ("dpaa2-switch: add VLAN based mirroring")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c