OSDN Git Service

net: ethernet: arc: fix error handling in emac_rockchip_probe
authorBranislav Radocaj <branislav@radocaj.org>
Mon, 11 Dec 2017 23:13:38 +0000 (00:13 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Dec 2017 18:57:06 +0000 (13:57 -0500)
commit2a9ee696c72a24d63529c76483fcd92d04b1d2b7
treeca8c58b979b0915b10533843f907f651027eafd4
parentaceef61ee56898cfa7b6960fb60b9326c3860441
net: ethernet: arc: fix error handling in emac_rockchip_probe

If clk_set_rate() fails, we should disable clk before return.
Found by Linux Driver Verification project (linuxtesting.org).

Changes since v2 [1]:
* Merged with latest code changes

Changes since v1:
Update made thanks to David's review, much appreciated David.
* Improved inconsistent failure handling of clock rate setting
* For completeness of usecase, added arc_emac_probe error handling

Signed-off-by: Branislav Radocaj <branislav@radocaj.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/arc/emac_rockchip.c