OSDN Git Service

net: mscc: ocelot: Fix uninitialized error in ocelot_netdevice_event()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 7 Jun 2018 13:10:30 +0000 (15:10 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Jun 2018 20:54:39 +0000 (16:54 -0400)
commit2ac0e1524d9585f5261cebecca262da6cedc1d85
treee37e93c8debb78b6e27f7550c23aa9af1c597d46
parenteb55bbf865d9979098c6a7a17cbdb41237ece951
net: mscc: ocelot: Fix uninitialized error in ocelot_netdevice_event()

With gcc-4.1.2:

    drivers/net/ethernet/mscc/ocelot.c: In function ‘ocelot_netdevice_event’:
    drivers/net/ethernet/mscc/ocelot.c:1129: warning: ‘ret’ may be used uninitialized in this function

If the list iterated over by netdev_for_each_lower_dev() is empty, ret
is never initialized, and converted into a notifier return value.

Fix this by preinitializing ret to zero.

Fixes: a556c76adc052c97 ("net: mscc: Add initial Ocelot switch support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mscc/ocelot.c