OSDN Git Service

net: hso: fix NULL-deref on disconnect regression
authorJohan Hovold <johan@kernel.org>
Mon, 26 Apr 2021 08:11:49 +0000 (10:11 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Apr 2021 19:54:44 +0000 (12:54 -0700)
commit2ad5692db72874f02b9ad551d26345437ea4f7f3
tree52b1e6e72d07d7ae4cd029f9370542c6d21bfd1f
parentd0c5d18da2da00f3bf550286426fabd01cb63bde
net: hso: fix NULL-deref on disconnect regression

Commit 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device
unregistration") fixed the racy minor allocation reported by syzbot, but
introduced an unconditional NULL-pointer dereference on every disconnect
instead.

Specifically, the serial device table must no longer be accessed after
the minor has been released by hso_serial_tty_unregister().

Fixes: 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device unregistration")
Cc: stable@vger.kernel.org
Cc: Anirudh Rayabharam <mail@anirudhrb.com>
Reported-by: Leonardo Antoniazzi <leoanto@aruba.it>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Anirudh Rayabharam <mail@anirudhrb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/hso.c