OSDN Git Service

rtc: ds1672: fix unintended sign extension
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Feb 2019 18:04:49 +0000 (18:04 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:21:39 +0000 (10:21 +0100)
commit2ae344cd19ee293565975688a2cd2093596856a0
tree9bcfe73895b0cb80c8f4fe3afcadabc40c806cac
parent938d29820972c81b0be36a362900825ec3d88c62
rtc: ds1672: fix unintended sign extension

[ Upstream commit f0c04c276739ed8acbb41b4868e942a55b128dca ]

Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#138801 ("Unintended sign extension")

Fixes: edf1aaa31fc5 ("[PATCH] RTC subsystem: DS1672 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-ds1672.c