OSDN Git Service

block, bfq: Init saved_wr_start_at_switch_to_srt in unlikely case
authorDouglas Anderson <dianders@chromium.org>
Wed, 26 Jun 2019 19:59:19 +0000 (12:59 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 26 Jun 2019 22:25:35 +0000 (16:25 -0600)
commit2b50f230f76f8ef954f12ac34a648e1978f6adf0
treee7be66be7387ba0f2278b5a2ea68d581ef8ad146
parent2ad7a0cc8f8ec37b2f65f6990faae7dec0058d55
block, bfq: Init saved_wr_start_at_switch_to_srt in unlikely case

Some debug code suggested by Paolo was tripping when I did reboot
stress tests.  Specifically in bfq_bfqq_resume_state()
"bic->saved_wr_start_at_switch_to_srt" was later than the current
value of "jiffies".  A bit of debugging showed that
"bic->saved_wr_start_at_switch_to_srt" was actually 0 and a bit more
debugging showed that was because we had run through the "unlikely"
case in the bfq_bfqq_save_state() function.

Let's init "saved_wr_start_at_switch_to_srt" in the unlikely case to
something sane.

NOTE: this fixes no known real-world errors.

Reviewed-by: Paolo Valente <paolo.valente@linaro.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c