OSDN Git Service

USB: serial: quatech2: use irqsave() in USB's complete callback
authorJohn Ogness <john.ogness@linutronix.de>
Sat, 23 Jun 2018 22:32:10 +0000 (00:32 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 26 Jun 2018 12:52:15 +0000 (14:52 +0200)
commit2ba02c8dd063c4396111629e96dec5a3f231f995
treedda96ac6dd6f9a333ab7edcda53f8877b7727d7e
parent19bfbf462e8921d8e520bcc0a23ebc4988223631
USB: serial: quatech2: use irqsave() in USB's complete callback

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/quatech2.c