OSDN Git Service

cifs: potential memory leaks when parsing mnt opts
authorTaesoo Kim <tsgatesv@gmail.com>
Sat, 21 Mar 2015 23:08:30 +0000 (19:08 -0400)
committerSteve French <smfrench@gmail.com>
Sat, 21 Mar 2015 17:01:50 +0000 (12:01 -0500)
commit2bd50fb3d4d31f5168ecea221f291534cd0a96e9
treefbc079983364b9d761b111f52d7a581cf7fc5b48
parente1e9bda22d7ddf88515e8fe401887e313922823e
cifs: potential memory leaks when parsing mnt opts

For example, when mount opt is redundently specified
(e.g., "user=A,user=B,user=C"), kernel kept allocating new key/val
with kstrdup() and overwrite previous ptr (to be freed).

Althouhg mount.cifs in userspace performs a bit of sanitization
(e.g., forcing one user option), current implementation is not
robust. Other options such as iocharset and domainanme are similarly
vulnerable.

Signed-off-by: Taesoo Kim <tsgatesv@gmail.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/connect.c