OSDN Git Service

ALSA: usb-audio: Fix missing error check at mixer resolution test
authorTakashi Iwai <tiwai@suse.de>
Sat, 9 Nov 2019 18:16:58 +0000 (19:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Nov 2019 06:40:31 +0000 (07:40 +0100)
commit2cad75d7fcced86724c8ab575f6bfde95aa70ddb
treeae1cedf0e1d2e374247fd4c39e7c8fd286810d9e
parentfa8331fe31eb0f6d0f0bb0d32ffa81bf5338a1da
ALSA: usb-audio: Fix missing error check at mixer resolution test

commit 167beb1756791e0806365a3f86a0da10d7a327ee upstream.

A check of the return value from get_cur_mix_raw() is missing at the
resolution test code in get_min_max_with_quirks(), which may leave the
variable untouched, leading to a random uninitialized value, as
detected by syzkaller fuzzer.

Add the missing return error check for fixing that.

Reported-and-tested-by: syzbot+abe1ab7afc62c6bb6377@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191109181658.30368-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/mixer.c