OSDN Git Service

drm/i915: Fix comparison bug
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Mon, 28 Sep 2015 21:08:50 +0000 (23:08 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 30 Sep 2015 08:20:35 +0000 (10:20 +0200)
commit2d05fa16fefb9922e021e0b7db4a0c515558f103
treee6ca8cccefe91a79f32617e167bca140c74da3b3
parent120f5d28714b5c401179a1fd6010c86b13d912ff
drm/i915: Fix comparison bug

->stolen->start has type u64 aka unsigned long long; relying on the
difference (effectively cast to int) for sorting is wrong.

It wouldn't be a problem in practice if the values compared are always
within INT_MAX of each other (so that the difference is actually
representable in an int), but 440fd5283a87 ("drm/mm: Support 4 GiB and
larger ranges") strongly suggests that's not the case.

Note: atm we don't support more than about 1G of stolen, so this is
impossible currenlty.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
[danvet: Add note that this is impossible currently.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_debugfs.c