OSDN Git Service

Revert "gallium: Force blend color to 16-byte alignment"
authorTim Rowley <timothy.o.rowley@intel.com>
Wed, 13 Jul 2016 15:30:46 +0000 (10:30 -0500)
committerEmil Velikov <emil.l.velikov@gmail.com>
Thu, 21 Jul 2016 11:08:18 +0000 (12:08 +0100)
commit2e010ab1cceabf1fcf7c1f2c28a01bc8cfaf4fc9
treebe26a33845712bdcac4106d0cb4012be4ef9dfb4
parent0aae486a8b2397f3f976b94ed4dac2cb11cd5723
Revert "gallium: Force blend color to 16-byte alignment"

This reverts commit d8d6091a846ac2a40a011d512d6d57f6c8442e6a.

Heap allocations may be only 8-byte aligned on 32-bit system, and so having
members with 16-byte alignment (such as in the case where pipe_blend_color is
embedded in radeonsi's si_context) is undefined behavior which indeed causes
crashes when compiled with gcc -O3.

Cc: <mesa-stable@lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96835
Signed-off-by: Tim Rowley <timothy.o.rowley@intel.com>
Acked-by: Chuck Atkins <chuck.atkins@kitware.com>
(cherry picked from commit 29f53d793781b67a92bb95fe66d7d38adc5488bb)
src/gallium/include/pipe/p_state.h