OSDN Git Service

Fix some lit test ResourceWarnings on Windows
authorAdrian McCarthy <amccarth@google.com>
Tue, 18 Jun 2019 16:36:57 +0000 (16:36 +0000)
committerAdrian McCarthy <amccarth@google.com>
Tue, 18 Jun 2019 16:36:57 +0000 (16:36 +0000)
commit2e02d2b3a348b0775083a092aaae46df8c779f3d
tree9d530b2b4144730bb008afc0c950d06e2bbec989
parent51481b9bae5b4f293070afa9f987df3c5c0566e8
Fix some lit test ResourceWarnings on Windows

When running LLDB lit tests on Windows, the system selects a debug version
of Python, which was issuing lots of ResourceWarnings about files that
weren't closed.  There are two kinds of them, and each test triggered one
of each.

This patch fixes one kind by ensuring TestRunner explicitly close the
temporary files created for routing stderr.  This is important on Windows
but has no net effect on Posix systems.

The remaining ResourceWarnings are more elusive; the bug may lie in
the Python library subprocess.py, and it may be Windows-specific.

Differential Revision: https://reviews.llvm.org/D63102

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@363700 91177308-0d34-0410-b5e6-96231b3b80d8
utils/lit/lit/TestRunner.py