OSDN Git Service

jbd2: Don't call __bforget() unnecessarily
authorJan Kara <jack@suse.cz>
Fri, 9 Aug 2019 12:42:31 +0000 (14:42 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 21 Oct 2019 13:16:46 +0000 (09:16 -0400)
commit2e710ff03fc4599059eeda68c8de2383e65af825
tree6781e026345c545f7f483346fb3ac509170df567
parent6d69843e5d3f0c394e1e3004cc2b36efbe402b71
jbd2: Don't call __bforget() unnecessarily

jbd2_journal_forget() jumps to 'not_jbd' branch which calls __bforget()
in cases where the buffer is clean which is pointless. In case of failed
assertion, it can be even argued that it is safer not to touch buffer's
dirty bits. Also logically it makes more sense to just jump to 'drop'
and that will make logic also simpler when we switch bh_state_lock to a
spinlock.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20190809124233.13277-6-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/transaction.c