OSDN Git Service

drm/amd/display: fix memory leaks on error exit return
authorColin Ian King <colin.king@canonical.com>
Wed, 22 Nov 2017 16:47:35 +0000 (16:47 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 28 Nov 2017 22:55:40 +0000 (17:55 -0500)
commit2f2c3b36fc5a3dc9fd2cf22a2f368502a70eea5d
tree29e8f8f7a7341dc67c3d9a4c4f70f9b52ffb4c22
parent93984bbc70b3f321b8f6a3ec303e31b084e54230
drm/amd/display: fix memory leaks on error exit return

Currently in the case where some of the allocations fail for dce110_tgv,
dce110_xfmv, dce110_miv or dce110_oppv then the exit return path ends
up leaking allocated objects. Fix this by kfree'ing them before returning.
Also re-work the comparison of the null pointers to use the !ptr idiom.

Detected by CoverityScan, CID#1460246146032514603241460392
("Resource Leak")

Fixes: c4562236b3bc ("drm/amd/dc: Add dc display driver (v2)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c