OSDN Git Service

wilc1000: fix a loop timeout condition
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 19 Mar 2021 14:47:31 +0000 (17:47 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 17 Apr 2021 17:54:22 +0000 (20:54 +0300)
commit2f51061edab942988b1a3c057d21228e938603db
tree8e10880655904217dbb043a05441b15bc1062786
parentc81852a48e137c61e8c85863b5a5104acc1a8270
wilc1000: fix a loop timeout condition

If the loop fails, the "while(trials--) {" loop will exit with "trials"
set to -1.  The test for that expects it to end with "trials" set to 0
so the warning message will not be printed.

Fix this by changing from a post-op to a pre-op.  This does mean that
we only make 99 attempts instead of 100 but that's okay.

Fixes: f135a1571a05 ("wilc1000: Support chip sleep over SPI")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/YFS5gx/gi70zlIaO@mwanda
drivers/net/wireless/microchip/wilc1000/wlan.c