OSDN Git Service

igbvf: Use smp_rmb rather than read_barrier_depends
authorBrian King <brking@linux.vnet.ibm.com>
Fri, 17 Nov 2017 17:05:46 +0000 (11:05 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:37:24 +0000 (08:37 +0000)
commit2f7de4d5f525fc39c83e6c423e12f1954106bf38
tree949559e37721e55b806e9f78cb23140963d17f4d
parent391cdaaaa9d9ce6b4cdc659d94ae59f9384f5e37
igbvf: Use smp_rmb rather than read_barrier_depends

commit 1e1f9ca546556e508d021545861f6b5fc75a95fe upstream.

The original issue being fixed in this patch was seen with the ixgbe
driver, but the same issue exists with igbvf as well, as the code is
very similar. read_barrier_depends is not sufficient to ensure
loads following it are not speculatively loaded out of order
by the CPU, which can result in stale data being loaded, causing
potential system crashes.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/igbvf/netdev.c