OSDN Git Service

net: netxen: fix a missing check and an uninitialized use
authorKangjie Lu <kjlu@umn.edu>
Fri, 21 Dec 2018 06:22:32 +0000 (00:22 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Jan 2019 08:51:03 +0000 (09:51 +0100)
commit2fb13e2004e81c7e03700726642c2dbb271c64e8
tree4d9b2dd0c9f8db4b8b80a7c4f04864e3144f9b9f
parent8bb68ed82f0171b7bafdaf898dddca43850e7190
net: netxen: fix a missing check and an uninitialized use

[ Upstream commit d134e486e831defd26130770181f01dfc6195f7d ]

When netxen_rom_fast_read() fails, "bios" is left uninitialized and may
contain random value, thus should not be used.

The fix ensures that if netxen_rom_fast_read() fails, we return "-EIO".

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c