OSDN Git Service

Revert "usb: dwc3: pci: Use devm functions to get the phy GPIOs"
authorStephan Gerhold <stephan@gerhold.net>
Thu, 6 Dec 2018 18:42:28 +0000 (19:42 +0100)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Fri, 7 Dec 2018 06:13:32 +0000 (08:13 +0200)
commit3004cfd6204927c1294060b849029cf0c2651074
tree92ac59d17a44b439ad2e4fb2498795f2d6a9e889
parentd9d1dc817020773c010498f5f81bb49439f7c962
Revert "usb: dwc3: pci: Use devm functions to get the phy GPIOs"

Commit 211f658b7b40 ("usb: dwc3: pci: Use devm functions to get
the phy GPIOs") changed the code to claim the PHY GPIOs permanently
for Intel Baytrail devices.

This causes issues when the actual PHY driver attempts to claim the
same GPIO descriptors. For example, tusb1210 now fails to probe with:

  tusb1210: probe of dwc3.0.auto.ulpi failed with error -16 (EBUSY)

dwc3-pci needs to turn on the PHY once before dwc3 is loaded, but
usually the PHY driver will then hold the GPIOs to turn off the
PHY when requested (e.g. during suspend).

To fix the problem, this reverts the commit to restore the old
behavior to put the GPIOs immediately after usage.

Link: https://www.spinics.net/lists/linux-usb/msg174681.html
Cc: stable@vger.kernel.org
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/dwc3-pci.c