OSDN Git Service

drm/amdgpu: fix a signedness bug in __verify_ras_table_checksum()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 3 Jul 2021 09:44:12 +0000 (12:44 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 8 Jul 2021 19:17:02 +0000 (15:17 -0400)
commit3006c9245542609d3a11b856b6d17cfce747ca88
tree4688a9063d943a7c3eadcae40de20ccb75676afa
parent7b101c95486cffbc65be4b41eda0d49f8cbb0173
drm/amdgpu: fix a signedness bug in __verify_ras_table_checksum()

If amdgpu_eeprom_read() returns a negative error code then the error
handling checks:

if (res < buf_size) {

The problem is that "buf_size" is a u32 so negative values are type
promoted to a high positive values and the condition is false.  Fix
this by changing the type of "buf_size" to int.

Fixes: 63d4c081a556a1 ("drm/amdgpu: Optimize EEPROM RAS table I/O")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c