OSDN Git Service

i40e: define proper net_device::neigh_priv_len
authorKonstantin Khorenko <khorenko@virtuozzo.com>
Fri, 23 Nov 2018 16:10:28 +0000 (19:10 +0300)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 20 Dec 2018 20:02:26 +0000 (12:02 -0800)
commit31389b53b3e0b535867af9090a5d19ec64768d55
tree512c28eaa91cbedeac40993b1b2e37f7a920529e
parentcd0d465bb697a9c7bf66a9fe940f7981232f1676
i40e: define proper net_device::neigh_priv_len

Out of bound read reported by KASan.

i40iw_net_event() reads unconditionally 16 bytes from
neigh->primary_key while the memory allocated for
"neighbour" struct is evaluated in neigh_alloc() as

  tbl->entry_size + dev->neigh_priv_len

where "dev" is a net_device.

But the driver does not setup dev->neigh_priv_len and
we read beyond the neigh entry allocated memory,
so the patch in the next mail fixes this.

Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_main.c