OSDN Git Service

btrfs: handle error of get_old_root
authorNikolay Borisov <nborisov@suse.com>
Thu, 13 Sep 2018 08:35:10 +0000 (11:35 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 15 Oct 2018 15:23:31 +0000 (17:23 +0200)
commit315bed43fea532650933e7bba316a7601d439edf
treeffeeaefa9373a653a6c4dfc4d71a4b4beca5661f
parent28bee489828ca7da9f9a0247a3fbe695fc0df6b4
btrfs: handle error of get_old_root

In btrfs_search_old_slot get_old_root is always used with the assumption
it cannot fail. However, this is not true in rare circumstance it can
fail and return null. This will lead to null point dereference when the
header is read. Fix this by checking the return value and properly
handling NULL by setting ret to -EIO and returning gracefully.

Coverity-id: 1087503
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c