OSDN Git Service

gpiolib: fix up emulated open drain outputs
authorRussell King <rmk+kernel@armlinux.org.uk>
Sat, 7 Dec 2019 16:20:18 +0000 (16:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2020 09:19:01 +0000 (10:19 +0100)
commit316a9a84dbaf628b74d30fd3e1a5dac739e125ed
treecaa24742fc3e369465d4eb0795f55af634fae067
parentc89e7917a2144f97d30255ed9e62d23bba7555c9
gpiolib: fix up emulated open drain outputs

commit 256efaea1fdc4e38970489197409a26125ee0aaa upstream.

gpiolib has a corner case with open drain outputs that are emulated.
When such outputs are outputting a logic 1, emulation will set the
hardware to input mode, which will cause gpiod_get_direction() to
report that it is in input mode. This is different from the behaviour
with a true open-drain output.

Unify the semantics here.

Cc: <stable@vger.kernel.org>
Suggested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpiolib.c