OSDN Git Service

nf_conntrack: avoid kernel pointer value leak in slab name
authorLinus Torvalds <torvalds@linux-foundation.org>
Sat, 14 May 2016 18:11:44 +0000 (11:11 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 14 May 2016 19:04:43 +0000 (15:04 -0400)
commit31b0b385f69d8d5491a4bca288e25e63f1d945d0
treedcfd83aac04a069512c7188769a7fdaa03bef183
parentb91506586206140154b0b44cccf88c8cc0a4dca5
nf_conntrack: avoid kernel pointer value leak in slab name

The slab name ends up being visible in the directory structure under
/sys, and even if you don't have access rights to the file you can see
the filenames.

Just use a 64-bit counter instead of the pointer to the 'net' structure
to generate a unique name.

This code will go away in 4.7 when the conntrack code moves to a single
kmemcache, but this is the backportable simple solution to avoiding
leaking kernel pointers to user space.

Fixes: 5b3501faa874 ("netfilter: nf_conntrack: per netns nf_conntrack_cachep")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/nf_conntrack_core.c